Cool Cacti #21

janine9vn · 2025-09-13T02:24:06Z

No description provided.

This project contains documentation and recommended tooling configuration for projects to be submitted during a Python Discord Code Jam. Co-authored-by: Akarys42 <matteobertucci2004@gmail.com> Co-authored-by: ChrisLovering <chris.lovering.95@gmail.com> Co-authored-by: mbaruh <8bee278@gmail.com> Co-authored-by: fisher60 <39353605+fisher60@users.noreply.github.com>

Changes the local pre-commit hooks out for remote ones, as well as changes the action to use the pre-commit action, so pre-commit will no longer depend on your project manager's settings.

Global Actions

Renames workflow to Lint

Signed-off-by: GitHub <noreply@github.com>

- Use Python 3.10 instead of 3.9 - Update action versions to the newest major versions - Remove caching configuration since it's not doing anything useful (and we would rather not have teams deal with caching issues)

Signed-off-by: GitHub <noreply@github.com>

*although I added '.0' at the end of flake8-docstrings's requirement since it's present in the bot repository (where Kat got her versions anyway).

Update packaging and CI config for CJ9

Unfortunately installing isort from source errors out due to a poetry bug(?). Since isort 5.x has a stability policy active, let's just bump this so the template is usable (and upgrade the template properly later).

The screenshot is my own as I couldn't find a GitHub provided one that works unfortunately. Admittedly ugly.

…pletion

git-subtree-dir: cool-cacti git-subtree-mainline: 49c1216 git-subtree-split: 6e8dfa6

MrGrote · 2025-09-20T14:59:44Z

README

The overall README reads well. I would however change up the order a bit, start with a short description of the project, followed by instructions on how to install and run the project, and lastly the details of the project. The addition of images to the README is nice, however the leading / prevents the images from being showed and the alt text of each image is the same while it only matches the first image. It could use some information about development like how to use the tools folder.

Commit Quality

Most commit titles are descriptive of what the was changed in the commit, however they do tend to be a bit terse. There is an absence of commit bodies throughout the whole commit history which could have been used to add context to why the commit was done. I noticed a few commits that also snuck in small changes in other files where they could have been their own commit.

Code Quality

The project was well structured and makes good use of classes. I appreciate the use of custom Exceptions. Type hinting was used in many places the application. It would be nice to add them everywhere unless the JavaScript api makes it impossible in those situations. There is some duplication in planets.json that I wonder could reduced and created in python. The overall code quality was good and easy to follow, even though docstrings were missing in some places. There were some cases of commented out code in the codebase, try not to commit this.

Summary

It was fun to fly around the universe scanning objects, it was impressive to see that this could be done with just python. I appreciated that the earth was surrounded by thrash.

One oversight I have noticed is that the game doesn't pause after you reach the victory state, making it so that you can reach the failure state at the same time. The project description was set a whimsical message "No idea yet :)" at the start of development but was never changed later on to match the project.

MrGrote · 2025-09-20T15:01:30Z

cool-cacti/static/scripts/scene_descriptions.py

+
+    def render(self, ctx, timestamp):
+
+        # some temporary functionality for testing


It would be nice to be able to Toggle this testing mode with an env variable or a global

MrGrote · 2025-09-20T15:03:30Z

cool-cacti/static/scripts/scene_descriptions.py

+                self.is_bobbing_up = not self.is_bobbing_up
+
+        draw_black_background(ctx)
+        #self.stars.render(ctx, timestamp)


Suggested change

#self.stars.render(ctx, timestamp)

MrGrote · 2025-09-20T15:05:23Z

cool-cacti/static/scripts/stars.py

+            for star in replacement_stars:
+                self.stars.append(star)


Suggested change

for star in replacement_stars:

self.stars.append(star)

self.stars.extend(replacement_stars)

MrGrote · 2025-09-20T15:06:23Z

cool-cacti/tools/horizons_api/parsers.py

+    @abstractmethod
+    def parse(self, text: str) -> object:


parse does not rely on the state of the object, it can be a staticmethod

MrGrote · 2025-09-20T15:12:11Z

cool-cacti/tools/horizons_api/client.py

+                data = response.read().decode()
+
+            if save_to:
+                with Path.open(save_to, "w") as f:


Suggested change

with Path.open(save_to, "w") as f:

with save_to.open("w") as f:

MrGrote · 2025-09-20T15:14:50Z

cool-cacti/static/scripts/spacemass.py

+        if self.highlighted:
+            if self.complete:
+                # log.debug("planet complete")
+                highlight = "#00ff00"
+            else:
+                # log.debug("planet not complete")
+                highlight = "#ffff00"  # yellow highlight


Don't leave commented out log statements behind in the code you commit.

MrGrote · 2025-09-20T15:17:34Z

cool-cacti/static/scripts/player.py

+            if "d" in keys or "ArrowRight" in keys:
+                dx += 1.75
+
+        # TODO: remove this, for testing momentum


It would be nice to have these work in a debug environment only instead of hardcoded

MrGrote · 2025-09-20T15:18:29Z

cool-cacti/static/scripts/player.py

+            # # Reduce scanner progress when hit by asteroid
+            # if hasattr(window, 'scanner') and window.scanner:
+            #     # Reduce progress by 2-6% of max progress based on damage taken
+            #     damage_taken = 100 / (distance_between_centers * 5 * asteroid.damage_mul
+            #     progress_loss = window.scanner._bar_max * (0.02 + (damage_taken / 1000) * 0.04)
+            #     window.scanner.scanning_progress = max(0, window.scanner.scanning_progress - progress_loss)
+            #     # log.debug("Scanner progress reduced by %f due to asteroid collision", progress_loss)
+
+            window.audio_handler.play_bang()
+            window.debris.generate_debris(self.get_position(), Position(ast_x, ast_y))
+
+    def nudge_towards(self, pos: Position, gravity_strength: float = 0.75) -> None:
+        distance = self.get_position().distance(pos)
+        if distance == 0: return
+
+        x_dir = (pos.x - self.x) / distance
+        y_dir = (pos.y - self.y) / distance
+
+        self.x += x_dir * gravity_strength
+        self.y += y_dir * gravity_strength
+
+        # x_dir = math.cos((pos.x - self.x )/(pos.y - self.y))
+        # y_dir = math.sin((pos.x - self.x )/(pos.y - self.y))
+
+        # if abs(self.momentum[0]) < 1:
+        #     self.momentum[0] += x_dir * momentum_amount
+        # if abs(self.momentum[1]) < 1:
+        #     self.momentum[1] += y_dir * momentum_amount
+


Two large sections of commented out code

swfarnsworth · 2025-09-28T03:28:12Z

cool-cacti/static/credits.txt

+
+
+
+42


I finally understand

swfarnsworth · 2025-09-28T03:29:30Z

cool-cacti/static/scripts/asteroid.py

+        col = self.sprite_index % self.grid_cols
+        row = self.sprite_index // self.grid_cols


This would have been a good opportunity to use the divmod builtin.

jb3 and others added 30 commits July 9, 2021 19:19

Makes Precommit Manager Independent

d0762d4

Changes the local pre-commit hooks out for remote ones, as well as changes the action to use the pre-commit action, so pre-commit will no longer depend on your project manager's settings.

Adds Project Manager Samples

c04c75f

Merge pull request #2 from python-discord/global-actions

3d5f617

Global Actions

Renames workflow to Lint

17c5f86

Merge pull request #3 from onerandomusername/patch-1

bb83538

Renames workflow to Lint

remove flake8 plugins

63bbaa0

Signed-off-by: GitHub <noreply@github.com>

update Python version to 3.10

d0c694a

Signed-off-by: GitHub <noreply@github.com>

update flake8 ignores

4b993de

Signed-off-by: GitHub <noreply@github.com>

remove unused flake8 plugins from documentation

1c9a4d0

Signed-off-by: GitHub <noreply@github.com>

remove removed flake8 codes from sample output

432b93a

Signed-off-by: GitHub <noreply@github.com>

Update lint CI configuration for CJ9

e5d557a

- Use Python 3.10 instead of 3.9 - Update action versions to the newest major versions - Remove caching configuration since it's not doing anything useful (and we would rather not have teams deal with caching issues)

only run workflow on commit to main branch

d1c92f6

Signed-off-by: GitHub <noreply@github.com>

Bump linting tools as Kat suggested

f1e9289

*although I added '.0' at the end of flake8-docstrings's requirement since it's present in the bot repository (where Kat got her versions anyway).

Remove D100 from README since we're ignoring it anyway

c49d624

Merge pull request #5 from python-discord/update-ci

1ced0aa

Update packaging and CI config for CJ9

Hotfix: bump isort (5.10.1 -> 5.12.0)

a926999

Unfortunately installing isort from source errors out due to a poetry bug(?). Since isort 5.x has a stability policy active, let's just bump this so the template is usable (and upgrade the template properly later).

Replace (and remove) broken images in README

3e38115

The screenshot is my own as I couldn't find a GitHub provided one that works unfortunately. Admittedly ugly.

Update pre-commit-hooks version

17c8122

Replace flake8 and isort with ruff

5b70abb

Update Python version to 3.12

6467281

Update CI github actions

95f2aa4

Clean up comments

7b0b37c

Rename LICENSE to LICENSE.txt

057f4d2

Bump dependency versions

bf560ad

Update README

a3b49ac

Ignore redundant docstring lint rule

c45ca52

Bump Ruff to v0.5.0

298dfde

Add note about Poetry config

7c1b9c4

Merge pull request #8 from lemonyte/update-2024

d5fd7be

fluffy-marmot and others added 19 commits August 18, 2025 02:58

Merge branch 'colored-stars'

1723966

change credits music track

a8da8b1

added 'cheats' info for judges convenience

626caa0

delete requirements.txt, using alternates

df7ae15

increased player speed and increased player hp after every planet com…

8208e0b

…pletion

fix hp overflow

3d94ea1

ok its safe enough...

b1462f3

change music attribution to preferred

2341de5

quick readme notes

52ec6fc

readme rough draft

288d259

readme second draft

daf0fc3

Update README.md with installation and usage steps

f2c2ba7

added yt link

9c3c107

work on readme, add screenshots

2b36bcf

work on readme, add screenshots

1f90982

merge

0fc2770

readme stuff

d0a6e58

add some code examples to readme

6e8dfa6

Add 'cool-cacti/' from commit '6e8dfa63e83a5ebe644dbc66b5c559f7144c3e3c'

be8b74c

git-subtree-dir: cool-cacti git-subtree-mainline: 49c1216 git-subtree-split: 6e8dfa6

MrGrote reviewed Sep 20, 2025

View reviewed changes

swfarnsworth reviewed Sep 28, 2025

View reviewed changes

cool-cacti/static/credits.txt

42 No newline at end of file

Copy link

Member

swfarnsworth Sep 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I finally understand

swfarnsworth reviewed Sep 28, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Cool Cacti #21

Cool Cacti #21

Uh oh!

janine9vn commented Sep 13, 2025

Uh oh!

MrGrote commented Sep 20, 2025

Uh oh!

MrGrote Sep 20, 2025

Uh oh!

MrGrote Sep 20, 2025

Uh oh!

MrGrote Sep 20, 2025

Uh oh!

MrGrote Sep 20, 2025

Uh oh!

MrGrote Sep 20, 2025

Uh oh!

MrGrote Sep 20, 2025

Uh oh!

MrGrote Sep 20, 2025

Uh oh!

MrGrote Sep 20, 2025

Uh oh!

swfarnsworth Sep 28, 2025

Uh oh!

swfarnsworth Sep 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants


		def render(self, ctx, timestamp):

		# some temporary functionality for testing

	for star in replacement_stars:
	self.stars.append(star)
	self.stars.extend(replacement_stars)

	with Path.open(save_to, "w") as f:
	with save_to.open("w") as f:

		col = self.sprite_index % self.grid_cols
		row = self.sprite_index // self.grid_cols

Uh oh!

Cool Cacti #21

Are you sure you want to change the base?

Cool Cacti #21

Uh oh!

Conversation

janine9vn commented Sep 13, 2025

Uh oh!

MrGrote commented Sep 20, 2025

README

Commit Quality

Code Quality

Summary

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants